Check zero for avgTimePerQuery #5904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dweitzman
reviewed
Mar 9, 2020
| resultItems[i] = &statsResultItem{ | ||
| Query: plan.Original, | ||
| AvgTimePerQuery: time.Duration(plan.ExecTime.Nanoseconds() / int64(plan.ExecCount)), | ||
| AvgTimePerQuery: time.Duration(avgTimePerQuery), | ||
| PercentTimeOfReads: float64(100 * plan.ExecTime / readOnlyTime), |
There was a problem hiding this comment.
You still need to convert all these integral denominators to floats to prevent divide-by-zero panic()s, as per the comment in the closed PR
Creating new PRs for each round of code review makes it trickier for people to keep track of the conversation and previous comments. In case you weren't aware, force-pushing to your existing branch on github will update an existing PR.
There was a problem hiding this comment.
Thanks, am kind of new to use Github system. Messed up a bit so created a newer branch. Let me update the code according to comment
There was a problem hiding this comment.
Cast the dominators to float64
Signed-off-by: Mingjian Liu <mingjianliu@pinterest.com>
sougou
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a simple fix as @dweitzman suggested from #5895
Signed-off-by: Mingjian Liu mingjianliu@pinterest.com