Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Vtexplains StripComments #5984

Merged
merged 4 commits into from
Apr 2, 2020
Merged

Fix Vtexplains StripComments #5984

merged 4 commits into from
Apr 2, 2020

Commits on Mar 28, 2020

  1. Fix Vtexplains StripComments 

    Signed-off-by: Saif Alharthi <saif@saifalharthi.me>

Modify for better readability

Signed-off-by: Saif Alharthi <saif@saifalharthi.me>

Make sure anything inside qoutations will not be removed

Signed-off-by: Saif Alharthi <saif@saifalharthi.me>

Modity test for readablity

Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
    @saifalharthi
    saifalharthi committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    1ddeee0 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2020

  1. Use Parser to handle comments if parseable 

    Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
    @saifalharthi
    saifalharthi committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    e907bdb View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2020

  1. Try to use SplitMarginComments instead of having StripComments() sepa… 

    …rately

Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    9b2f210 View commit details
    Browse the repository at this point in the history

  2. Remove Partition comment from test to match current behaviour for Vitess 

    Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
    @saifalharthi
    saifalharthi committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    309c888 View commit details
    Browse the repository at this point in the history