Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added planning logic for IN and NOT IN when values are null #6152

Merged
merged 2 commits into from
May 7, 2020
Merged

Added planning logic for IN and NOT IN when values are null #6152

merged 2 commits into from
May 7, 2020

Conversation

systay
Copy link
Collaborator

@systay systay commented May 6, 2020

No description provided.

@systay systay requested a review from sougou as a code owner May 6, 2020 15:38
@systay
Added planning logic for IN and NOT IN when values are null
b37c50a 
Signed-off-by: Andres Taylor <andres@planetscale.com>
harshit-gangal
harshit-gangal reviewed May 6, 2020
View reviewed changes
Copy link
Member

@harshit-gangal harshit-gangal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be added to select null end to end test

@systay
Added end to end tests for NULL planning
ac2e593 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@harshit-gangal harshit-gangal merged commit 4d3eb9f into vitessio:master May 7, 2020
@deepthi deepthi added this to the v7.0 milestone Jul 17, 2020
@ameetkotian ameetkotian mentioned this pull request Aug 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@systay @harshit-gangal @deepthi