Refactor tabletmanager table filtering logic #6242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systay
reviewed
May 29, 2020
| } | ||
|
|
||
| for _, tc := range tcs { | ||
| f, err := NewTableFilter(tc.tables, tc.excludeTables, tc.includeViews) |
systay
approved these changes
May 29, 2020
deepthi
reviewed
May 29, 2020
| @@ -63,94 +63,129 @@ func (tds TableDefinitions) Swap(i, j int) { | |||
| tds[i], tds[j] = tds[j], tds[i] | |||
| } | |||
|
|
|||
| // FilterTables returns a copy which includes only whitelisted tables | |||
| type TableFilter struct { | |||
There was a problem hiding this comment.
nit: a doc comment will be nice.
There was a problem hiding this comment.
there's already docs in both NewTableFilter and FilterTables, so I felt it was redundant. if you insist, i will copy the content.
There was a problem hiding this comment.
Precommit didn't catch this? All exported names require a comment.
If it's not useful outside this package, it's better to make it unexported.
Same with NewTableFilter.
There was a problem hiding this comment.
I've added comment. This is intended to actually be used outside in the mysqlctl package, and replace FilterTables, in a separate PR. Hence these are exported methods.
Signed-off-by: Toliver Jue <toliver@planetscale.com>
deepthi
approved these changes
Jun 2, 2020
rohit-nayak-ps
added a commit
to planetscale/vitess
that referenced
this pull request
Jun 2, 2020
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
deepthi
added a commit
that referenced
this pull request
Jun 2, 2020
…aking-change Reverting breaking change relating to filter regular expressions in #6242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Break up
tabletmanagerFilterTables into a filter and application, so that filtering is reusable.Signed-off-by: Toliver Jue toliver@planetscale.com