Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Materialize: Use ApplySchema for bulk schema change #6251

Merged
merged 2 commits into from
Jun 2, 2020
Merged

Materialize: Use ApplySchema for bulk schema change #6251

merged 2 commits into from
Jun 2, 2020

Conversation

teejae
Copy link
Contributor

@teejae teejae commented May 31, 2020 •
edited
Loading

  • Use ApplySchema to more efficiently apply large schema changes
  • Get TabletAlias once
  • Add more logging to Materialize operation

Signed-off-by: Toliver Jue toliver@planetscale.com

@teejae teejae requested a review from sougou as a code owner May 31, 2020 07:24
@teejae teejae force-pushed the tj-materialize-apply-schema branch 2 times, most recently from 2e0968d to c545361 Compare May 31, 2020 08:28
Materialize: Use ApplySchema for bulk schema change
02be677 
Signed-off-by: Toliver Jue <toliver@planetscale.com>
@teejae teejae force-pushed the tj-materialize-apply-schema branch from c545361 to 02be677 Compare May 31, 2020 08:30
@teejae teejae requested review from morgo and systay June 2, 2020 02:47
@rohit-nayak-ps
Materialize: AllowReplication needs to be true for binlogs to see ddls
7efa695 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
rohit-nayak-ps approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, code looks good.

Tests are all passing now.

Local examples worked after AllowReplication=true and other cluster test flakiness seem resolved after a few reruns ...

@sougou sougou merged commit 6a1d3cc into vitessio:master Jun 2, 2020
@deepthi deepthi added this to the v7.0 milestone Jul 27, 2020
@ameetkotian ameetkotian mentioned this pull request Aug 20, 2020
Merged
@deepthi deepthi mentioned this pull request Aug 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@sougou sougou Awaiting requested review from sougou

@deepthi deepthi Awaiting requested review from deepthi

@enisoc enisoc Awaiting requested review from enisoc

@morgo morgo Awaiting requested review from morgo

@systay systay Awaiting requested review from systay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@teejae @systay @rohit-nayak-ps @deepthi @sougou