Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds more keyspace, table and tablet_type to logs emitted to files #6282

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Adds more keyspace, table and tablet_type to logs emitted to files #6282

merged 2 commits into from
Jun 9, 2020

Conversation

rafael
Copy link
Member

@rafael rafael commented Jun 8, 2020 •
edited
Loading

Description

  • Small PR that adds make sure keyspace, tablet and tablet_type is propagated to logs when available.

@rafael
Adds more keyspace, table and tablet_type to logs emitted to files
0fa0a97 
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
@rafael rafael requested a review from sougou as a code owner June 8, 2020 19:56
@rafael rafael requested a review from systay June 8, 2020 19:56
@rafael
Update tests to reflect new changes
efb8692 
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
deepthi
deepthi approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepthi deepthi merged commit 945e105 into vitessio:master Jun 9, 2020
@rafael rafael deleted the add-ks-table-tablet-type-to-logs branch June 15, 2020 17:13
ajm188 pushed a commit to tinyspeck/vitess that referenced this pull request Jul 1, 2020
@deepthi @ajm188
Merge pull request vitessio#6282 from tinyspeck/add-ks-table-tablet-t…
3c423ee 
…ype-to-logs

Adds more keyspace, table and tablet_type to logs emitted to files
@ajm188 ajm188 mentioned this pull request Jul 1, 2020
Closed
@deepthi deepthi added this to the v7.0 milestone Jul 27, 2020
ameetkotian pushed a commit to tinyspeck/vitess that referenced this pull request Aug 19, 2020
@deepthi @ameetkotian
Merge pull request vitessio#6282 from tinyspeck/add-ks-table-tablet-t…
2cca2ae 
…ype-to-logs

Adds more keyspace, table and tablet_type to logs emitted to files
@ameetkotian ameetkotian mentioned this pull request Aug 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@sougou sougou Awaiting requested review from sougou

@systay systay Awaiting requested review from systay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rafael @deepthi