Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prepared statements in column specs #6298

Merged
merged 3 commits into from
Jun 15, 2020

Conversation

luisfmcalado
Copy link
Contributor

The following PR solves the issue with a prepared statement in the column specs. It seems that the prepared step wasn't sending the binding variables to the tablet.
Since this is my first time contributing to Vitess I hope I'm not breaking something else but the solution was to create empty binding variables for the execShard to execute properly.
It's also missing the tests because I didn't see where It should be created in the first place.

Issue: #6287

Signed-off-by: Luis Calado <luisfmcalado@gmail.com>
Signed-off-by: Luis Calado <luisfmcalado@gmail.com>
@deepthi deepthi requested a review from systay June 11, 2020 01:04
@deepthi
Copy link
Member

deepthi commented Jun 11, 2020

hi @luisfmcalado! we welcome contributors!
Do you think you can add a testcase here?
https://github.com/vitessio/vitess/blob/master/go/test/endtoend/preparestmt/stmt_methods_test.go

Signed-off-by: Luis Calado <luisfmcalado@gmail.com>
@luisfmcalado
Copy link
Contributor Author

luisfmcalado commented Jun 11, 2020

hi @luisfmcalado! we welcome contributors!
Do you think you can add a testcase here?
https://github.com/vitessio/vitess/blob/master/go/test/endtoend/preparestmt/stmt_methods_test.go

done @deepthi. It covers the scenario that I was trying to solve.

Copy link
Collaborator

@systay systay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants