Fix prepared statements in column specs #6298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR solves the issue with a prepared statement in the column specs. It seems that the prepared step wasn't sending the binding variables to the tablet.
Since this is my first time contributing to Vitess I hope I'm not breaking something else but the solution was to create empty binding variables for the
execShard
to execute properly.It's also missing the tests because I didn't see where It should be created in the first place.
Issue: #6287