Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow charset introducers for vindex columns #6301

Merged
merged 3 commits into from
Jun 11, 2020
Merged

Allow charset introducers for vindex columns #6301

merged 3 commits into from
Jun 11, 2020

Conversation

systay
Copy link
Collaborator

@systay systay commented Jun 10, 2020

Fixes: #6236

@systay
Allow _binary for vindex columns
ebb09fe 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay requested a review from sougou as a code owner June 10, 2020 18:53
@systay systay marked this pull request as draft June 10, 2020 18:53
@systay
Allow _latin1 and _utf8 charset introducers
61e9e29 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay marked this pull request as ready for review June 11, 2020 07:05
@systay systay requested a review from deepthi June 11, 2020 07:05
@systay systay changed the title Allow _binary for vindex columns Allow charset introducers for vindex columns Jun 11, 2020
@systay
Clean up testdata
532dea3 
Signed-off-by: Andres Taylor <andres@planetscale.com>
deepthi
deepthi approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepthi deepthi merged commit f672f4f into vitessio:master Jun 11, 2020
@deepthi deepthi deleted the charset_introducer branch June 11, 2020 15:08
@deepthi deepthi added this to the v7.0 milestone Jul 17, 2020
@ameetkotian ameetkotian mentioned this pull request Aug 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@deepthi deepthi deepthi approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.0
Development

Successfully merging this pull request may close these issues.

Allow charset introducers with vindex column values
3 participants
@systay @deepthi @harshit-gangal