Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not rewrite the type description for CAST #6304

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Do not rewrite the type description for CAST #6304

merged 1 commit into from
Jun 11, 2020

Conversation

systay
Copy link
Collaborator

@systay systay commented Jun 11, 2020

No description provided.

@systay
Do not rewrite the type description for CAST
9d6e45b 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay requested a review from sougou as a code owner June 11, 2020 15:19
@acharis
Copy link
Contributor

acharis commented Jun 11, 2020

thanks, Andreś!

i think we're still wondering why we started seeing this problem now...

@sougou sougou merged commit d5cbdf2 into vitessio:master Jun 11, 2020
@deepthi deepthi added this to the v7.0 milestone Jul 17, 2020
@ameetkotian ameetkotian mentioned this pull request Aug 20, 2020
Merged
This was referenced Sep 3, 2020
Closed
Closed
@indera-shsp
Copy link
Contributor

We are still seeing this in a recent version

select CAST('x' AS char(100));
+-------------------------+
| convert('x', char(100)) |
+-------------------------+
| x                       |
+-------------------------+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sougou sougou sougou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@systay @acharis @indera-shsp @sougou @deepthi