Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Golangci-lint Workflow and hooks ( Excluding handling errors) #6385

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Golangci-lint Workflow and hooks ( Excluding handling errors) #6385

merged 1 commit into from
Jul 1, 2020

Conversation

Akilan1999
Copy link
Contributor

No description provided.

@Akilan1999 Akilan1999 requested a review from sougou as a code owner June 26, 2020 11:22
@Akilan1999 Akilan1999 requested a review from morgo as a code owner June 29, 2020 22:04
deepthi
deepthi reviewed Jun 30, 2020
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looking good. Just a few minor changes requested.

go/cmd/mysqlctl/mysqlctl.go Show resolved Hide resolved
go/cmd/zkctl/zkctl.go Show resolved Hide resolved
go/mysql/binlog_event_make_test.go Show resolved Hide resolved
@Akilan1999
fixing linter errors
1cc4907 
Signed-off-by: akilan <as251@hw.ac.uk>
deepthi
deepthi approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thank you for the contribution!

@deepthi deepthi merged commit 7621d7e into vitessio:master Jul 1, 2020
@deepthi deepthi mentioned this pull request Jul 18, 2020
Closed
@deepthi deepthi added this to the v7.0 milestone Jul 27, 2020
@ameetkotian ameetkotian mentioned this pull request Aug 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@sougou sougou Awaiting requested review from sougou

@morgo morgo Awaiting requested review from morgo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Akilan1999 @deepthi