Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statistics for reserved connections #6402

Merged
merged 4 commits into from
Jul 10, 2020
Merged

Statistics for reserved connections #6402

merged 4 commits into from
Jul 10, 2020

Conversation

systay
Copy link
Collaborator

@systay systay commented Jul 1, 2020

Adds statistics to around reserved connections:

  • Active reserved connections
  • Timeouts
  • Creation counter
  • Connection duration

systay and others added 3 commits July 7, 2020 16:03
@systay @harshit-gangal
reserved-conn-stats: added stats
a0774b5 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@harshit-gangal
added reservedID to logstats
2959483 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
reserve-conn-stats: added reserve connection logging on release
b1388dd 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
reserve-conn-stats: added active reserved conn stats and unit tests
cc21751 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal marked this pull request as ready for review July 7, 2020 17:43
sougou
sougou approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you intend to do more work on this. If not, this can be merged.

@harshit-gangal harshit-gangal merged commit 4146436 into vitessio:master Jul 10, 2020
@deepthi deepthi added this to the v7.0 milestone Jul 17, 2020
@ameetkotian ameetkotian mentioned this pull request Aug 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sougou sougou sougou approved these changes

@deepthi deepthi Awaiting requested review from deepthi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@systay @sougou @deepthi @harshit-gangal