Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linter fixes, remove staticcheck hook because golangci-lint includes it #6416

Merged
merged 2 commits into from
Jul 7, 2020

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Jul 7, 2020

Signed-off-by: deepthi deepthi@planetscale.com

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi requested a review from sougou as a code owner July 7, 2020 00:25
Signed-off-by: deepthi <deepthi@planetscale.com>
Copy link
Contributor

@PrismaPhonic PrismaPhonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sougou sougou merged commit c43bab5 into vitessio:master Jul 7, 2020
@deepthi deepthi added this to the v7.0 milestone Jul 17, 2020
@deepthi deepthi deleted the ds-lint-fixes branch July 20, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants