Update user-facing terminology in the vtctld2 UI #6481
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...because I'm a little bit cowardly of making logic changes to an unfamiliar UI, I figured it was less risky to only change the display values and leave the Typescript alone (for now). Unfortunately, this leaves a handful of instances of oppressive terminology in the code base, but they won't be user-facing.
The static files and rice-box.go changes were auto-generated with the new build tooling.
One thing worth noting is that this overwrites the files to go/vt/vtctld/rice-box.go that were made in 1acb6e0. Trying to parse that diff is an absolute nightmare, so I was unsuccessful in copying over the changes. 😞 I don't see any updates to the unbuilt
web/vtctld2/
files that might suggest what the changes were -- @deepthi do you happen to remember what they were, and if I should copy them over?I also updated the copyright date in the new FE build scripts per @rohit-nayak-ps's suggestion on #6473. :)
Here's one example of the UI before vs. after: