-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vtgate routing cleanup: remove routeOptions #6531
Merged
harshit-gangal
merged 10 commits into
vitessio:master
from
planetscale:ss-vg1-no-route-options
Aug 18, 2020
Merged
vtgate routing cleanup: remove routeOptions #6531
harshit-gangal
merged 10 commits into
vitessio:master
from
planetscale:ss-vg1-no-route-options
Aug 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce the number of options to just one. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
This is mostly an undo of this PR #4833 |
harshit-gangal
approved these changes
Aug 18, 2020
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
I went ahead and resolved merge conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I previously added an experimental feature that allowed the routing schema to provide multiple viable targets for a table (if it was materialized in other places). This would allow vtgate to choose the best option depending on the query.
The feature was implemented using the "routing options" approach. It was not a good design because it wasn't going to play well with future optimizer approaches. The main difference is that it optimizers like to try multiple options top-down, whereas routeOptions was implemented using something low level and mostly opaque. Additionally, it distorted the design of the symbol table by moving some of those elements into the routing Option.
This change removes all those complexities.
Along the way, I found some subtle bugs in the code that evaluates mergeability of routes, which I've fixed. I've also filed #6529 to make sure
SelectNone
is handled correctly.