Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to backtick schema names properly #6550

Merged
merged 4 commits into from
Aug 12, 2020

Conversation

systay
Copy link
Collaborator

@systay systay commented Aug 11, 2020

In order to allow schema names that need to be escaped, we must backtick db names before sending them to MySQL.

Fixes #6545

aquarapid and others added 2 commits August 6, 2020 14:19
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay requested a review from sougou as a code owner August 11, 2020 07:00
Signed-off-by: Andres Taylor <andres@planetscale.com>
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some unit tests are failing and need to be adjusted accordingly.

Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay merged commit bd4b3b6 into vitessio:master Aug 12, 2020
@askdba askdba added this to the v8.0 milestone Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExecuteFetchAsDba and ExecuteFetchAsAllPrivs do not escape db names.
4 participants