Implemented pitr testcase #6594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gle shard. It also tests pitr for multiple shards when a single shard is resharded. Signed-off-by: Pankaj Gavit <pankaj.gavit777@gmail.com>
systay
reviewed
Aug 20, 2020
| @@ -38,7 +38,7 @@ type mysqlMaster struct { | |||
|
|
|||
| // newBinlogServer returns an instance of binlog server | |||
| func newBinlogServer(hostname string, port int) (*binLogServer, error) { | |||
| dataDir := path.Join(os.Getenv("VTDATAROOT"), binlogDataDir) | |||
| dataDir := path.Join(os.Getenv("VTDATAROOT"), binlogDataDir+"_"+fmt.Sprintf("%d", port)) | |||
There was a problem hiding this comment.
nit: if we are doing fmt.Sprintf, can't the whole string be created this way instead of mixing concatenation and sprintf?
There was a problem hiding this comment.
Used fmt.Sprintf() func to create a string
systay
reviewed
Aug 20, 2020
| @@ -0,0 +1,523 @@ | |||
| package pitr | |||
There was a problem hiding this comment.
Added license header
Signed-off-by: Pankaj Gavit <pankaj.gavit777@gmail.com>
Signed-off-by: Pankaj Gavit <pankaj.gavit777@gmail.com>
deepthi
reviewed
Aug 24, 2020
| @@ -0,0 +1,539 @@ | |||
| /* | |||
There was a problem hiding this comment.
Because you renamed the file, I can't tell what changed. Can you rename this to pitr_test.go?
There was a problem hiding this comment.
The codeflow of current testcase is totally different from the previous testcase. As there will be a lot of diff between the previous testcase and current testcase, I kept a different filename.
If required, I will change the filename back to pitr_test.go
deepthi
approved these changes
Aug 25, 2020
Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Signed-off-by: Pankaj Gavit <pankaj.gavit777@gmail.com>
pankajgavit
force-pushed
the
sharded_pitr
branch
from
21fcd2e
to
6baadd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pitr_test.goand incorporated them in theTestPITRRecoverytestFixes :
restore.goingetGTIDFromTimestampwhere it fails to recover when we have one last event after therestoreTime/snapshotTime.Signed-off-by: Pankaj Gavit <pankaj.gavit777@gmail.com>