Rewrite SHOW TABLES #6615
Merged
Rewrite SHOW TABLES #6615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
approved these changes
Aug 26, 2020
go/vt/vtgate/executor.go
Outdated
Comment on lines
633
to
640
| if show.ShowTablesOpt != nil && show.ShowTablesOpt.DbName != "" { | ||
| if destKeyspace == "" { | ||
| // Change "show tables from <keyspace>" to "show tables" directed to that keyspace. | ||
| destKeyspace = show.ShowTablesOpt.DbName | ||
| } | ||
| show.ShowTablesOpt.DbName = "" | ||
| } | ||
| sql = sqlparser.String(show) |
There was a problem hiding this comment.
we can revert this change.
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing a query using SHOW TABLES, a common query is something :
because the underlying database does not always use the same database name as the keyspace name, we need to rewrite the query before sending it down to MySQL.
Fixes #6446