select query on lookup table to lock the row #6620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…consistenlookup Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…PDATE in select query Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…cursor interface to fake vcursors Signed-off-by: Harshit Gangal <harshit@planetscale.com>
sougou
reviewed
Aug 25, 2020
There was a problem hiding this comment.
Looks like you're doing an unconditional for update in the select. That may be aggressive and could fail also in read-only cases.
I think you should do it only for DMLs.
Also, I'm wondering if you can leverage an existing e2e test for this. If not, then this is fine.
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
|
@sougou I think we are only adding the |
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Oh nvm. I see now :) |
systay
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6604
The select query on a lookup vindex will take exclusive lock if it is a dml query and is executed in a transaction.