restore: do not change tablet type to RESTORE if not actually performing a restore #6679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing a restore Signed-off-by: deepthi <deepthi@planetscale.com>
deepthi
force-pushed
the
ds-should-restore
branch
from
badcf0c
to
2fb3acf
Compare
|
Re: "Also would it make sense for Restore() to call ShouldRestore()?" from #6641 (comment) I looked at the code paths and decided that the chunk of code at the beginning of |
enisoc
reviewed
Sep 9, 2020
…tore if mysql doesn't come up Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
deepthi
added a commit
to planetscale/vitess
that referenced
this pull request
Sep 9, 2020
…ing a restore (vitessio#6679) * restore: do not change tablet type to RESTORE if not actually performing a restore Signed-off-by: deepthi <deepthi@planetscale.com> * restore: cleanup usage of ErrExistingDB, improve comments, do not restore if mysql doesn't come up Signed-off-by: deepthi <deepthi@planetscale.com> * restore: remove ErrExistingDB which is no longer needed Signed-off-by: deepthi <deepthi@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: deepthi deepthi@planetscale.com