Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of environment variables easier to troubleshoot #6735

Merged
merged 2 commits into from
Sep 17, 2020
Merged

Make use of environment variables easier to troubleshoot #6735

merged 2 commits into from
Sep 17, 2020

Conversation

systay
Copy link
Collaborator

@systay systay commented Sep 17, 2020 •
edited
Loading

Makes endtoend tests easier to troubleshoot

  • Panics if environment variables are missing instead of using empty strings
  • If a mysql process fails to start, the tests will try again, but do a lot more logging the second time
  • Makefile fails if required env vars are missing

@systay
check environment variables before using them
ded063d 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay requested a review from sougou as a code owner September 17, 2020 07:39
@systay systay changed the title check environment variables before using them Make use of environment variables easier to troubleshoot Sep 17, 2020
shlomi-noach
shlomi-noach approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future-me, can you please add some description in the PR's main comment, so we know what the problem is that PR solves? 🙏 🙇

@systay
Makes endtoend tests easier to troubleshoot
785c51a 
 * Panics if environment variables are missing instead of using empty strings
 * If a mysql process fails to start, the tests will try again, but do a lot more logging the second time

Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay merged commit b854ebf into vitessio:master Sep 17, 2020
@systay systay deleted the env-var-checks branch September 17, 2020 10:21
@deepthi deepthi mentioned this pull request Sep 17, 2020
Merged
@systay systay restored the env-var-checks branch September 18, 2020 06:54
@askdba askdba added this to the v8.0 milestone Oct 6, 2020
@setassociative setassociative mentioned this pull request Mar 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@systay @shlomi-noach @askdba