Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SHOW (DATABASES|VITESS_SHARDS|VITESS_TABLETS) LIKE #6750

Merged
merged 15 commits into from
Sep 28, 2020
Merged

Add support for SHOW (DATABASES|VITESS_SHARDS|VITESS_TABLETS) LIKE #6750

merged 15 commits into from
Sep 28, 2020

Commits on Sep 19, 2020

  1. Update parser to support `SHOW DATABASES LIKE '%nnn%' 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Sep 19, 2020
    Configuration menu
    Copy the full SHA
    74400ca View commit details
    Browse the repository at this point in the history

  2. Add VITESS_KEYSPACES and KEYSPACES to keyword variables 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Sep 19, 2020
    Configuration menu
    Copy the full SHA
    49229f4 View commit details
    Browse the repository at this point in the history

  3. Use sqlparser types instead of raw strings 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Sep 19, 2020
    Configuration menu
    Copy the full SHA
    835e391 View commit details
    Browse the repository at this point in the history

  4. Add parser support for showing filtered tablets/shards 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Sep 19, 2020
    Configuration menu
    Copy the full SHA
    32aa372 View commit details
    Browse the repository at this point in the history

  5. Include filters 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Sep 19, 2020
    Configuration menu
    Copy the full SHA
    2df54d6 View commit details
    Browse the repository at this point in the history

  6. Add support in the executor for SHOW VITESS_SHARDS LIKE '...' 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Sep 19, 2020
    Configuration menu
    Copy the full SHA
    4e20e01 View commit details
    Browse the repository at this point in the history

  7. Add support for filtering tablets by hostname 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Sep 19, 2020
    Configuration menu
    Copy the full SHA
    4f60721 View commit details
    Browse the repository at this point in the history

  8. Add log line to avoid deadbranch check, remove unused function 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Sep 19, 2020
    Configuration menu
    Copy the full SHA
    935819e View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2020

  1. Update formatting for SHOW, add test cases 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    7ff93ea View commit details
    Browse the repository at this point in the history

  2. Add tests cases, ensure rows is never nil from showTablets 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    72816d3 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2020

  1. Use KeywordString 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    ff51d90 View commit details
    Browse the repository at this point in the history

  2. Remove debug log lines, standardize actual log lines 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    804d00c View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. Update tests 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    f2b437b View commit details
    Browse the repository at this point in the history

  2. Update the rest of TestExecutorShow to use require/assert 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    fe5986f View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2020

  1. Merge remote-tracking branch 'upstream/master' into am_show_filtered_… 

    …tablets

Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    d1c5b4c View commit details
    Browse the repository at this point in the history