tm: call setReadOnly inside ChangeTabletType #6762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… advertise itself as MASTER while mysql is still read_only Signed-off-by: deepthi <deepthi@planetscale.com>
…cked will. Fix tests Signed-off-by: deepthi <deepthi@planetscale.com>
rafael
approved these changes
Sep 22, 2020
ameetkotian
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Sep 24, 2020
tm: call setReadOnly inside ChangeTabletType
ameetkotian
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Sep 29, 2020
tm: call setReadOnly inside ChangeTabletType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During PlannedReparents, it is possible that a tablet advertises itself as MASTER while mysql is still read_only because
ChangeTabletTypetriggers a health broadcast.This PR adds a call to
SetReadOnlyinsideChangeTabletTypewhen the new tablet_type is MASTER.Remove the call from
PromoteReplicasince it is no longer needed there.Signed-off-by: deepthi deepthi@planetscale.com