VStreamer: handle SET statements in the binlog stream #6772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
changed the title
rohit-nayak-ps
requested review from
harshit-gangal and
systay
as code owners
sougou
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are certain SET statements that seem to make it to the binlogs. One reported by a user is the "SET PASSWORD" query.
Currently vstreamer throws an error in the logs if it encounters a SET. Note that data replication is not affected. However this
causes errors in the logs.
We are going to send an OTHER event just like for DBA commands like REPAIR or ACL ones like GRANT/REVOKE.
A few interesting points which caused challenges while testing:
an ALTER ... This seems to be off by default
So for simplicity the test only runs if log_builtin_as_identified_by_password is supported (for our CI that would be the 56 and 57 flavors).
Signed-off-by: Rohit Nayak rohit@planetscale.com