Add optional ignore to delete statement #6802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
saifalharthi
requested review from
harshit-gangal and
systay
as code owners
harshit-gangal
approved these changes
Sep 30, 2020
Comment on lines
+151
to
152
| Ignore Ignore | ||
| Comments Comments |
There was a problem hiding this comment.
nit: in declaration also we can move Ignore after Comments.
|
@harshit-gangal @systay I see the failing test a flaky one in VTExplain. However, I am not fully sure if this fail is a result of my code changes. |
systay
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6722
Signed-off-by: Saif Alharthi saif@saifalharthi.me