Fix error around breaking of multistatements #6824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a multistatement query is received, any errors should abort the execution of the remaining queries. The `execQuery` and `handleNextCommand` were returning an error, but not actually using the error value - just checking if it was nil or not. We need to be able to know on the outside of `execQuery` if an error occured and if it was an error we need to close the connection for or if it was a simple execution error. This is a squashed backport of vitessio#6808 Signed-off-by: Andres Taylor <andres@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a multistatement query is received, any errors should abort the execution of the remaining queries.
The
execQueryandhandleNextCommandwere returning an error, but not actually using the error value - just checking if it was nil or not.We need to be able to know on the outside of
execQueryif an error occured and if it was an error we need to close the connection for or if it was a simple execution error.This is a squashed backport of #6808