-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional options support for SELECT INTO and LOAD DATA #6872
Additional options support for SELECT INTO and LOAD DATA #6872
Conversation
…paces Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100 can you kindly elaborate a bit on what this PR does?
Which options are these?
Not sure I parse the sentence. What are the bypass queries? |
Ignore that question, I can see the options in |
bypass queries are the ones where the user first specifies the shard that they want the query to run on i.e. "use ks@replica:-80". |
Signed-off-by: GuptaManan100 <manan@planetscale.com>
…aces Signed-off-by: GuptaManan100 <manan@planetscale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would need few end to end test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks very good to me, though this isn't in my comfort zone. I'd change the wording on error messages, or invest in documentation. What "bypass" is, our users cannot know at this time.
Signed-off-by: GuptaManan100 <manan@planetscale.com>
I have changed the error messages as discussed. I have also added the documentation for "bypass" in my todo list and will do that as a separate PR. |
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
…est case Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Support for using
SELECT INTO
andLOAD DATA
on unsharded keyspaces, in addition to already supported bypass queries.Provide additional options support for SELECT INTO and LOAD statements.
From the MySQL docs:
This PR adds support for all the optional options following
INTO OUTFILE 'file_name'