fix ListBackups for gcp and az to work with root directory #6873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yujie Zhu <yujiezhu718@gmail.com>
y00j
force-pushed
the
yz-vtbackup-cleaner-gcp-az-compatibility
branch
from
c5b9ddc
to
287def5
Compare
deepthi
changed the title
deepthi
reviewed
Oct 14, 2020
| searchPrefix = objName(dir, "") | ||
| } | ||
|
|
||
| log.Infof("ListBackups: [azblob] container: %s, directory: %v", *containerName, searchPrefix) |
There was a problem hiding this comment.
Is this log line required? will it spam the logs?
There was a problem hiding this comment.
this log was originally in there, I just moved it below the searchPrefix assignment. I'm fine either way to remove it or not
There was a problem hiding this comment.
we can leave it in for now and remove it later if it becomes noisy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the search prefix to prevent it from becoming
//when the directory is at rootSimilar to #6732
Signed-off-by: Yujie Zhu yujiezhu718@gmail.com