Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing some flaky tests #6874

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Fixing some flaky tests #6874

merged 1 commit into from
Oct 14, 2020

Conversation

shlomi-noach
Copy link
Contributor

This will be an iterative PR, and I'll try and fix some tests as we go along.

@shlomi-noach
Fixing flaky tests
b4026ae 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Contributor Author

Hmmm, "All checks have passed". Either these commits fixed vtxplain_flaky_test, or we're too lucky for the test to incidentally pass.

@systay systay mentioned this pull request Oct 14, 2020
Closed
@harshit-gangal
Copy link
Member

We should remove it from flaky_test now. :)

@harshit-gangal
Copy link
Member

Hmmm, "All checks have passed". Either these commits fixed vtxplain_flaky_test, or we're too lucky for the test to incidentally pass.

This is what Andres figured out. So this should be it.

@systay systay merged commit 74b376d into vitessio:master Oct 14, 2020
@systay systay deleted the fix-some-flaky-tests branch October 14, 2020 08:37
@deepthi deepthi mentioned this pull request Oct 15, 2020
Merged
@rafael rafael mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systay systay systay approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shlomi-noach @harshit-gangal @systay