VDiff: make enums comparable #6880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…arable types test Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohitnayak
requested review from
harshit-gangal,
sougou and
systay
as code owners
harshit-gangal
approved these changes
Oct 14, 2020
sougou
reviewed
Oct 15, 2020
There was a problem hiding this comment.
This is likely not 100% correct because byte comparing enum for inequality may yield a different result than mysql. In the case of the other data types, it will still work because mysql's text rendering of those values coincidentally works correctly also.
We should ideally differentiate between equality vs inequality comparability. Let's merge this, but fix forward.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a table with a column of type Enum is participating in a vreplication workflow, the replication itself works. However VDiff fails while comparing enum values from source and target.
Signed-off-by: Rohit Nayak rohit@planetscale.com