vttablet: ignore errors if extracted gh-ost binary is identical to installed binary #6928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to installed binary Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
systay
approved these changes
Oct 23, 2020
deepthi
reviewed
Oct 23, 2020
go/cmd/vttablet/vttablet.go
Outdated
| ghostBinary, err := riceBox.Bytes("gh-ost") | ||
| if err != nil { | ||
| return err | ||
| } | ||
| if err := ioutil.WriteFile(binaryFileName, ghostBinary, 0755); err != nil { | ||
| // One possibility of failure is that gh-ost is up and running. In that case, | ||
| // let's pause and check if running h-ost is exact same binary as the one we wish to extract. |
There was a problem hiding this comment.
Suggested change
| // let's pause and check if running h-ost is exact same binary as the one we wish to extract. | |
| // let's pause and check if the running gh-ost is exact same binary as the one we wish to extract. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix to #6924
This fix is most useful for development environments. When
vttabletstarts, it tries to extractgh-ost. If unable to, it checks whethergh-ostis already installed and is identical to the intended version. If so,vttabletignores the error and proceeds.