Route INFORMATION_SCHEMA queries #6932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
…ma and table_name Signed-off-by: Andres Taylor <andres@planetscale.com>
Normally we route queries while planning. For information_schema queries that target routed tables, we need to be able to do the routing in the engine Primitives Signed-off-by: GuptaManan100 <manan@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
force-pushed
the
information_schema_routing_rules
branch
from
3c2009e
to
f57954b
Compare
…a_routing_rules Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
changed the title
When there are predicates for the table_name and table_schema, but the table is not routed, Vitess was failing the query. Signed-off-by: Andres Taylor <andres@planetscale.com>
Comment on lines
+24
to
27
| "vitess.io/vitess/go/vt/vtgate/vindexes" | ||
|
|
||
| "golang.org/x/sync/errgroup" | ||
| "vitess.io/vitess/go/vt/sqlparser" |
There was a problem hiding this comment.
looks like a formatting issue?
Comment on lines
34
to
44
| if isTableSchema { | ||
| if rut.eroute.SysTableTableSchema != nil { | ||
| return vterrors.Errorf(vtrpcpb.Code_INVALID_ARGUMENT, "two predicates for table_schema not supported") | ||
| } | ||
| rut.eroute.SysTableTableSchema = out | ||
| } else { | ||
| if rut.eroute.SysTableTableName != nil { | ||
| return vterrors.Errorf(vtrpcpb.Code_INVALID_ARGUMENT, "two predicates for table_name not supported") | ||
| } | ||
| rut.eroute.SysTableTableName = out | ||
| } |
There was a problem hiding this comment.
I think the expression can contain apart from table_schema and table_name. We should check the else condition as well.
There was a problem hiding this comment.
We do handle other expressions in the WHERE clause. When we are doing pushFilter on primitiveBuilder, we look at these expressions to do the routing, but then we still add these expressions to the query:
https://github.com/vitessio/vitess/blob/master/go/vt/vtgate/planbuilder/select.go#L310
Signed-off-by: Andres Taylor <andres@planetscale.com>
harshit-gangal
approved these changes
Nov 2, 2020
Signed-off-by: Andres Taylor <andres@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For queries against
INFORMATION_SCHEMA.tables, when the user is asking for a specific table that is routed, Vitess needs to look up where the table is routed, and send the query to a shard in that keyspace.There are two predicates we look for -
TABLE_SCHEMA = ?andTABLE_NAME = ?. Vitess uses the values we are searching for to know how to route the query.Fixes #6894