Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0] Fix error handling in olap mode #6940

Merged
merged 4 commits into from
Oct 26, 2020
Merged

[8.0] Fix error handling in olap mode #6940

merged 4 commits into from
Oct 26, 2020

Commits on Oct 24, 2020

  1. added e2e test for insert statement in olap mode 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    5e67474 View commit details
    Browse the repository at this point in the history

  2. check error before calling callback 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    a284ae0 View commit details
    Browse the repository at this point in the history

  3. fix test to delete row afterwards 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    cc8c593 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2020

  1. addressed review comment 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    811d288 View commit details
    Browse the repository at this point in the history