Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make VReplication relay log size & rows configurable. #6992

Merged
merged 2 commits into from
Dec 15, 2020
Merged

Make VReplication relay log size & rows configurable. #6992

merged 2 commits into from
Dec 15, 2020

Conversation

aquarapid
Copy link
Contributor

  • Make default relay log size signficantly larger,
    30k -> 250k. Improves performance tables with
    larger rows significantly.
  • Fix bug where we were fetching MaxSize instead of
    MaxItems number of rows from VReplication source.

Signed-off-by: Jacques Grove aquarapid@gmail.com

@aquarapid
* Make VReplication relay log size & rows configurable.
6093dc5 
* Make default relay log size signficantly larger,
  30k -> 250k. Improves performance tables with
  larger rows significantly.
* Fix bug where we were fetching MaxSize instead of
  MaxItems number of rows from VReplication source.

Signed-off-by: Jacques Grove <aquarapid@gmail.com>
shlomi-noach
shlomi-noach reviewed Nov 8, 2020
View reviewed changes
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 30k is clearly exceedingly small.

rohit-nayak-ps
rohit-nayak-ps previously requested changes Nov 8, 2020
View reviewed changes
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but tests need to pass ...
Looks like the failing tests are due to the flakiness around that time when artifact repos were not available and a rerun should fix it

@deepthi deepthi changed the title * Make VReplication relay log size & rows configurable. Make VReplication relay log size & rows configurable. Nov 24, 2020
@deepthi deepthi dismissed rohit-nayak-ps’s stale review November 24, 2020 22:32

Tests are now passing.

@aquarapid
Bump default max vreplication row buffering to 5k
b519991 
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
@hallaroo hallaroo requested a review from deepthi December 15, 2020 15:49
rohit-nayak-ps
rohit-nayak-ps approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deepthi deepthi merged commit b14c13a into vitessio:master Dec 15, 2020
@deepthi deepthi deleted the jg_relaylog branch December 15, 2020 19:36
@askdba askdba added this to the v9.0 milestone Dec 23, 2020
@rafael rafael mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlomi-noach shlomi-noach shlomi-noach left review comments

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@sougou sougou Awaiting requested review from sougou

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal

@systay systay Awaiting requested review from systay

@deepthi deepthi Awaiting requested review from deepthi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@aquarapid @deepthi @shlomi-noach @rohit-nayak-ps @askdba