Fix COM_STMT_EXECUTE packet decode #7020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
|
Decision needs to be taken if this is safe to be merged. More details are in issue linked to this PR. |
systay
reviewed
Nov 12, 2020
harshit-gangal
changed the title
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
systay
approved these changes
Nov 13, 2020
dbussink
added a commit
to dbussink/vitess
that referenced
this pull request
Jul 23, 2024
In vitessio#7020 the logic was changed to always map YEAR to binary. But that is wrong, since this breaks the text protocol. Instead, we need to make sure that when we parse the binary data for prepared statements, we treat YEAR there as binary. That ensures we can parse it the way it's encoded in practice in the protocol (and not how it is documented). Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6986
MYSQL_TYPE_YEAR in binary protocol needs to be handled as Varbinary than YEAR i.e. treat as length encoded string over uint16.