Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Planning and Parsing Support for Create Index of MySQL 5.7 #7024

Merged
merged 14 commits into from
Nov 18, 2020
Merged

Adds Planning and Parsing Support for Create Index of MySQL 5.7 #7024

merged 14 commits into from
Nov 18, 2020

Conversation

GuptaManan100
Copy link
Member

@GuptaManan100 GuptaManan100 commented Nov 12, 2020 •
edited
Loading

Adds Planning and Parsing Support for Create Index of MySQL 5.7

@GuptaManan100
Added tests
0f36c12 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Parsing for create index statements complete
0567df0 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100 GuptaManan100 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Parser labels Nov 12, 2020
@GuptaManan100
Merged Master
cc05e31 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100 GuptaManan100 changed the title Adds Complete Parsing Support for all constructs of mysql 5.7 Adds Parsing Support for Create Index of mysql 5.7 Nov 13, 2020
@systay systay changed the title Adds Parsing Support for Create Index of mysql 5.7 Adds Parsing Support for Create Index of MySQL 5.7 Nov 13, 2020
@GuptaManan100
Add OnlineHints to Parsing and convert fields to strings
008b88b 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Converted DDL into DDLStatements in builder
1eedd46 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Use Ast incase the query is fully parsed
bfa23dd 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
PlanBuilder at tabletserver changed to use DDLStatement
e55cb63 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
shlomi-noach
shlomi-noach approved these changes Nov 15, 2020
View reviewed changes
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Unfortunately for me, I didn't consider CREATE INDEX when parsing online DDL; while it's a valid query, I only planned for ALTER TABLE. Moreover, gh-ost only supports ALTER TABLE form.

What I would like to consider is to have a func (*CreateIndex) ToAlterTable() *Statement function. Given the fields in CreateIndex struct I feel like this is reasonable to accomplish. What do you think?

@GuptaManan100
Merged Master
2dc045b 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Copy link
Member Author

Yes, we can have that function for converting CREATE INDEX query to ALTER TABLE. For now the focus is on mysql compatibility and I will revisit this when the planning and parsing for other constructs is done too. I will add it to the TODO list https://github.com/vitessio/vitess/projects/7. Is that alright?

@GuptaManan100
TabletServer now uses the AST generated query in case it is fully parsed
fcb20fb 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@shlomi-noach
Copy link
Contributor

I will add it to the TODO list

sounds good! I'm happy to author that change myself.

@GuptaManan100 GuptaManan100 changed the title Adds Parsing Support for Create Index of MySQL 5.7 Adds Planning and Parsing Support for Create Index of MySQL 5.7 Nov 16, 2020
@GuptaManan100
Routing works correctly for create index queries
7fc96cb 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Added unit tests for QueryExecutor
832c6e5 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100 GuptaManan100 marked this pull request as ready for review November 16, 2020 09:42
@GuptaManan100
Added Test for a table not in vschema in unsharded keyspace
210aa1a 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Merged Master
e663cee 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Fixed test
fd8335e 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
harshit-gangal
harshit-gangal reviewed Nov 18, 2020
View reviewed changes
go/vt/vtgate/planbuilder/testdata/ddl_cases.txt Outdated
Comment on lines 142 to 145
"Keyspace": {
"Name": "user",
"Sharded": true
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this not be main keyspace?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it is fixed in next commit.

@harshit-gangal harshit-gangal merged commit 095e468 into vitessio:master Nov 18, 2020
@askdba askdba added this to the v9.0 milestone Nov 27, 2020
@rafael rafael mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal harshit-gangal left review comments

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@systay systay Awaiting requested review from systay

Assignees
No one assigned
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.
6 participants
@GuptaManan100 @shlomi-noach @systay @harshit-gangal @deepthi @askdba