Adding ddl_strategy session variable
#7042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach
requested review from
harshit-gangal,
sougou and
systay
as code owners
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach
changed the title
ddl_strategy session variable
harshit-gangal
approved these changes
Nov 16, 2020
| case DDLStrategyNormal: | ||
| return DDLStrategyNormal, nil | ||
| default: | ||
| return DDLStrategyNormal, fmt.Errorf("Unknown online DDL strategy: '%v'", strategy) |
There was a problem hiding this comment.
nit: either return value or error
There was a problem hiding this comment.
in this case DDLStrategyNormal is equilavent to returning empty string, so this may be ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #6782 (comment)
Additional contexts: #6926, #6689
This PR adds a new session variable
ddl_strategy. Right now this variable is unused; it just exists and it is readable and writable.The objective is to later be able to:
and have that
ALTER TABLErun as online DDL.