-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support statsd for vitess #7072
Conversation
Signed-off-by: crowu <y.wu4515@gmail.com>
Signed-off-by: crowu <y.wu4515@gmail.com>
8b2accd
to
d3e8244
Compare
Signed-off-by: crowu <y.wu4515@gmail.com>
Signed-off-by: crowu <y.wu4515@gmail.com>
Signed-off-by: crowu <y.wu4515@gmail.com>
Not sure if this build failure is related to my change https://github.com/vitessio/vitess/pull/7072/checks?check_run_id=1449541891 @sougou do you happen to know why this might fail on top of your head? Thanks! |
We have seen this test fail before (randomly). I don't think it is related to your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. It's good to see that the feature is disabled unless stats_address is specified.
This tries to address #7064 and add very basic initial supports for statsd (we might need to tweak it a bit more later)
This PR mainly does 2 things:
stats.Timings
as histogram for now until we have better solution to store and export metrics directly as statsd.timing