-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OnlineDDL: request_context/migration_context #7082
OnlineDDL: request_context/migration_context #7082
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Still TODO: pass |
Since VExec is not GA yet, it doesn't have to be backward compatible. |
…t-context Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Converged into a single param, |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Because Online DDL is still experimental, and because I need this functionality for some internal POC, I'm just modifying the schema without beackwards compatibility. |
ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We add a context to an OnlineDDL request:
vtctl
,vtctld/api
,vtgate
)vtctl
execution)This context (not to confuse with
golang
context.Context) can be later used to group and associate migrations. For example, knowing that a few migration requests all came from the samevtctl
call, means we should probably prioritize to run them together.