-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Online DDL: ddl_type column #7097
Merged
shlomi-noach
merged 6 commits into
vitessio:master
from
planetscale:online-ddl-ddl-type-column
Dec 10, 2020
Merged
Online DDL: ddl_type column #7097
shlomi-noach
merged 6 commits into
vitessio:master
from
planetscale:online-ddl-ddl-type-column
Dec 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach
requested review from
deepthi,
rohit-nayak-ps and
sougou
as code owners
December 2, 2020 12:26
Only review after #7083 is merged. |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Documentation PR: vitessio/website#623 |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
🙏 @vitessio/ps-vitess request for review |
rohit-nayak-ps
approved these changes
Dec 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Will resolve conflict after merging #7083 |
…pe-column Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #6926
This PR extends #7083
Given #7083 adds support for
CREATE
andDROP
in online DDL, this PR adds a new column,ddl_action
, to the backendschema_migrations
table.Values of this column are necessarily one of:
create
alter
drop
which are the three supported online DDL types.
This column gets populated via
vtctld
and is communicated viavtctl OnlineDDL show ...
command.