Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online DDL: ddl_type column #7097

Merged
merged 6 commits into from
Dec 10, 2020

Conversation

shlomi-noach
Copy link
Contributor

Context: #6926
This PR extends #7083

Given #7083 adds support for CREATE and DROP in online DDL, this PR adds a new column, ddl_action, to the backend schema_migrations table.

Values of this column are necessarily one of:

  • create
  • alter
  • drop

which are the three supported online DDL types.

This column gets populated via vtctld and is communicated via vtctl OnlineDDL show ... command.

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Contributor Author

Only review after #7083 is merged.

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Contributor Author

Documentation PR: vitessio/website#623

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Contributor Author

🙏 @vitessio/ps-vitess request for review

Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shlomi-noach
Copy link
Contributor Author

Will resolve conflict after merging #7083

…pe-column

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach merged commit 448f382 into vitessio:master Dec 10, 2020
@shlomi-noach shlomi-noach deleted the online-ddl-ddl-type-column branch December 10, 2020 08:56
@askdba askdba added this to the v9.0 milestone Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants