Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vtctl to make install-local #7125

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Add vtctl to make install-local #7125

merged 1 commit into from
Dec 8, 2020

Conversation

ankane
Copy link
Contributor

@ankane ankane commented Dec 6, 2020

Hi, thanks for this project! This adds vtctl to make install-local (noticed it was missing when following the Getting Started docs).

@ankane ankane requested a review from sougou as a code owner December 6, 2020 19:48
@ankane ankane mentioned this pull request Dec 6, 2020
Closed
5 tasks
@ankane
Added vtctl to make install-local
e8a8681 
Signed-off-by: Andrew Kane <andrew@ankane.org>
deepthi
deepthi approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any harm in adding vtctl to install-local.
It's so cool that you are adding vitess to brew install 🙇‍♀️

@deepthi deepthi merged commit c467dc4 into vitessio:master Dec 8, 2020
@ankane
Copy link
Contributor Author

ankane commented Dec 10, 2020

Thanks @deepthi!

@askdba askdba added this to the v9.0 milestone Dec 10, 2020
@rafael rafael mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ankane @deepthi @askdba