Refactor Show plans #7185
Merged
Refactor Show plans #7185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
GuptaManan100
approved these changes
Dec 16, 2020
| maxLenField := &querypb.Field{Name: "Maxlen", Type: sqltypes.Int32} | ||
| fields = append(fields, maxLenField) | ||
|
|
||
| charsets := []string{utf8, utf8mb4} |
There was a problem hiding this comment.
Does this mean we only support 2 charsets? Cant we send this query down to any MySQL instance and return its output?
There was a problem hiding this comment.
This is just about moving code. On VTGate level we are not able to handle it. I think we can send it down.
cc: @deepthi
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
NO
Status
DRAFT
Description
Refactor some of the show queries and move to planner.
Related Issue(s)
List related PRs against other branches:
Closes #6997
Impacted Areas in Vitess
List general components of the application that this PR will affect: