Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sequence table support for vtexplain #7186

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

csquared
Copy link

Backport

NO

Status

READY

Description

Adds support for detecting sequence tables via the required comment. Works transparently and what a user expects so I don't think it requires extra docs. Added a unit test for it.

Related Issue(s)

Todos

  • [x ] Tests
  • [x ] Documentation

Makes feature work as expected so no need for extra docs.

Deployment Notes

None

Impacted Areas in Vitess

List general components of the application that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build
  • VTExplain

Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @csquared!
LGTM, but the DCO needs to be fixed and then we have to wait for the tests to pass.

Signed-off-by: Chris Continanza <ccontinanza@stripe.com>
@csquared
Copy link
Author

Whoops - my bad about the DCO - just pushed!
Let's see how the tests go :)

@deepthi
Copy link
Member

deepthi commented Dec 15, 2020

Not sure why the CI workflows are not starting. I'm going to try closing and re-opening this PR to see if that helps.

@deepthi deepthi closed this Dec 15, 2020
@deepthi deepthi reopened this Dec 15, 2020
@csquared
Copy link
Author

Also, thanks for the welcome! Feels great to contribute :)

@deepthi deepthi merged commit e4b5f65 into vitessio:master Dec 15, 2020
@csquared csquared deleted the sequence-tables-in-vtexplain branch December 15, 2020 23:48
@askdba askdba added this to the v9.0 milestone Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants