add sequence table support for vtexplain #7186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Continanza <ccontinanza@stripe.com>
csquared
force-pushed
the
sequence-tables-in-vtexplain
branch
from
53b8217
to
01143aa
Compare
|
Whoops - my bad about the DCO - just pushed! |
|
Not sure why the CI workflows are not starting. I'm going to try closing and re-opening this PR to see if that helps. |
|
Also, thanks for the welcome! Feels great to contribute :) |
deepthi
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
NO
Status
READY
Description
Adds support for detecting sequence tables via the required comment. Works transparently and what a user expects so I don't think it requires extra docs. Added a unit test for it.
Related Issue(s)
Todos
Makes feature work as expected so no need for extra docs.
Deployment Notes
None
Impacted Areas in Vitess
List general components of the application that this PR will affect: