Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated pull request template to add more clarity #7193

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Updated pull request template to add more clarity #7193

merged 1 commit into from
Dec 21, 2020

Conversation

shlomi-noach
Copy link
Contributor

Followup to an internal discussion, I've made some changes to the pull request template:

  • Removed "Status" section. If the PR is a draft, then the developer should "create draft pull request", this is a built in GitHub feature.
  • Aggregated "Backport" together with tests & documentation checkboxes. Everything is in a checkbox
  • Clarified "test" and "documentation" meaning
  • Turned most instruction to HTML comment. The developer will be able to read them. Most (in my experience) submissions may forget/neglect to actually modify those instructions. So having them as comment means they're readable upon submission, but hidden after submission.

cc @deepthi @askdba

@shlomi-noach
Updated pull request template to add more clarity
be15013 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
deepthi
deepthi approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll leave it open for a bit in case others have feedback.

@deepthi deepthi requested a review from a team December 16, 2020 16:50
@askdba
Copy link
Contributor

askdba commented Dec 19, 2020

LGTM

@shlomi-noach shlomi-noach merged commit f667091 into vitessio:master Dec 21, 2020
@shlomi-noach shlomi-noach deleted the pr-template-improvements branch December 21, 2020 07:08
@askdba askdba added this to the v9.0 milestone Dec 23, 2020
@rafael rafael mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@askdba askdba askdba approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shlomi-noach @askdba @deepthi