Do vschema_customer_sharded.json before create_customer_sharded.sql. #7210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing create_customer_sharded.sql (removing auto-increments) before vschema_customer_sharded.json (applying VIndex), there is a short period of time where INSERTs in the customer and corder tables would fail if the customer_id or order_id is not set. Doing vschema_customer_sharded.json before create_customer_sharded.sql remove this failure possibility. Signed-off-by: Jean-François Gagné <jfg956@users.noreply.github.com>
|
Related: vitessio/website#647 |
|
@shlomi-noach , before merging this just wanted to check with you about this failing test: https://github.com/vitessio/vitess/pull/7210/checks?check_run_id=1591367702. Is this related to your internal post this morning about the failing docker test? |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
It is. Just merged |
|
@rohit-nayak-ps tests now pass. I'll also keep an eye for other PRs. Merging this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing create_customer_sharded.sql (removing auto-increments) before vschema_customer_sharded.json (applying VIndex), there is a short period of time where INSERTs in the customer and corder tables would fail if the customer_id or order_id is not set. Doing vschema_customer_sharded.json before create_customer_sharded.sql remove this failure possibility.