Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Online DDL: DROP TABLE translated to RENAME TABLE statement #7221

Merged
merged 17 commits into from
Jan 5, 2021
Merged

Online DDL: DROP TABLE translated to RENAME TABLE statement #7221

merged 17 commits into from
Jan 5, 2021

Commits on Dec 22, 2020

  1. Online DDL: convert DROP to RENAME statements 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    53e6d4a View commit details
    Browse the repository at this point in the history

  2. an online DDL 'DROP TABLE' is now transformed into a 'RENAME TABLE'. 

    artifact tables are named after the migration UUID (this helps in tracking their origin)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    f7d564e View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2020

  1. vtgate: online DDL normalizes queries 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    1ac737c View commit details
    Browse the repository at this point in the history

  2. merge master 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    30b9682 View commit details
    Browse the repository at this point in the history

  3. online DDL executor converts a DROP TABLE to RENAME TABLE statement 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    1eaaf5a View commit details
    Browse the repository at this point in the history

  4. add tests from DROP TABLE, DROP TABLE IF EXISTS 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    f66b840 View commit details
    Browse the repository at this point in the history

  5. validating creation of GC table based on UUID 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    5dcf7e2 View commit details
    Browse the repository at this point in the history

  6. tablet executor: only accept CREATE, DROP, ALTER statements as online… 

    … DDL, otherwise consider them as direct regardless of ddl_strategy

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    c844a8d View commit details
    Browse the repository at this point in the history

  7. one more test 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    51d6042 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2020

  1. Merge remote-tracking branch 'upstream/master' into online-ddl-drop-t… 

    …o-rename

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    758fef4 View commit details
    Browse the repository at this point in the history

  2. if table is a GC table, just DROP it 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    45a5de7 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. test UUID uniqueness 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    379e900 View commit details
    Browse the repository at this point in the history

  2. typo 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    59458fb View commit details
    Browse the repository at this point in the history

  3. updates per review 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    ac4e855 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into online-ddl-drop-to-rename

    @shlomi-noach
    shlomi-noach authored Jan 5, 2021
    Configuration menu
    Copy the full SHA
    16ccb98 View commit details
    Browse the repository at this point in the history

  5. test uuid 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    4428549 View commit details
    Browse the repository at this point in the history

  6. implementing GetIfExists for DropTable and DropView 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    ef06391 View commit details
    Browse the repository at this point in the history