Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix meta data related operation hang when zk down #7228

Merged
merged 1 commit into from
Dec 28, 2020

Conversation

inolddays
Copy link
Contributor

@inolddays inolddays commented Dec 28, 2020

Signed-off-by: JohnnyThree whereshallyoube@gmail.com

How we reproduce the problem:

1.Bring up a normal vitess cluster with zk2 topo implementation

2.Execute zk-down.sh, Destroy zk cluster.

3.Execute an cmd related with meta data & cmd hang there

image

4. After Pr Modified:

image

Conclusion:

DialZK timeout seems does not take effect under such situation .
So here set context with timeout to make sure that dialZk will perform as expected

Description

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build

Signed-off-by: JohnnyThree <whereshallyoube@gmail.com>
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for hunting this down. I have no idea why the built-in timeout is not being honored. But this looks like a safe change.

@sougou sougou merged commit 81719f4 into vitessio:master Dec 28, 2020
@askdba askdba added this to the v9.0 milestone Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants