[8.0] don't try to compare varchars in vtgate #7270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we can't group together multiple varchar values into a IN query, because that forces use to compare varchar values on the vtgate level which we can't do correctly yet Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
changed the title
harshit-gangal
approved these changes
Jan 8, 2021
bezmax
reviewed
Jan 8, 2021
| @@ -80,7 +80,7 @@ func (lkp *lookupInternal) Lookup(vcursor VCursor, ids []sqltypes.Value, co vtga | |||
| if vcursor.InTransactionAndIsDML() { | |||
| sel = sel + " for update" | |||
| } | |||
| if !ids[0].IsIntegral() && !ids[0].IsBinary() { | |||
| if !ids[0].IsIntegral() { | |||
| // for non integral and binary type, fallback to send query per id | |||
There was a problem hiding this comment.
Comment needs to be updated to avoid confusion.
There was a problem hiding this comment.
👍 I'll fix this in master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can't group together multiple varchar values into a IN query,
because that forces use to compare varchar values on the vtgate
level which we can't do correctly yet
This is a backport of #7268 that solves #7254