Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to false for system settings to be changed per session at the database connection level #7299

Merged
merged 1 commit into from
Jan 16, 2021

Conversation

harshit-gangal
Copy link
Member

Description

Changing system settings at database connection level should be known to user and almost all libraries do this at start time which will impact how the Vitess connection pooling behaves.

Setting this to false for the release.

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving

… database connection level

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal added this to the v9.0 milestone Jan 15, 2021
@harshit-gangal harshit-gangal merged commit 96186a2 into vitessio:release-9.0 Jan 16, 2021
@harshit-gangal harshit-gangal deleted the disable-sys-var branch January 16, 2021 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants