Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vtadmin-web] Add CSS variables + fonts to VTAdmin #7309

Merged
merged 8 commits into from
Jan 18, 2021
Merged

[vtadmin-web] Add CSS variables + fonts to VTAdmin #7309

merged 8 commits into from
Jan 18, 2021

Conversation

doeg
Copy link
Contributor

@doeg doeg commented Jan 16, 2021 •
edited
Loading

Description

A small PR to add the fonts, colours, and other CSS variables per our Figma style guide. ✨ (The Figma project is still invite-only, so let me know if you'd like an invite!) :)

Always gotta start with dark mode! 😎 Haha.

Screen Shot 2021-01-15 at 10 27 44 PM

Screen Shot 2021-01-15 at 10 23 46 PM

Related Issue(s)

N/A

Checklist

  • Should this PR be backported? N/A
  • Tests were added or are not required N/A
  • Documentation was added or is not required N/A

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build
  • VTAdmin

@doeg
Add NotoSans + NotoMono fonts
c014431 
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg
Add typography variables + rules
9652b62 
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg
Add greyscale + initial theme variables
88c3b96 
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg
Add more colours + variables
67b0229 
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg
Use _ to denote theme-specific variables
118958f 
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg
Typographic nits + notes
a1473da 
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg
Add line height variables
299e9a7 
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg doeg requested a review from ajm188 as a code owner January 16, 2021 15:51
@doeg
Forgot the license (sigh)
aada696 
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg doeg changed the title Add CSS variables + fonts Add CSS variables + fonts to VTAdmin Jan 16, 2021
ajm188
ajm188 approved these changes Jan 16, 2021
View reviewed changes
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m

@rohit-nayak-ps rohit-nayak-ps merged commit fd5ae95 into vitessio:master Jan 18, 2021
@askdba askdba added this to the v9.0 milestone Jan 19, 2021
@doeg doeg added the Component: VTAdmin VTadmin interface label Mar 16, 2021
@doeg doeg changed the title Add CSS variables + fonts to VTAdmin [vtadmin-web] Add CSS variables + fonts to VTAdmin Mar 16, 2021
@eseokoh eseokoh mentioned this pull request May 31, 2021
Closed
@ajm188 ajm188 mentioned this pull request Jul 12, 2021
Merged
@doeg doeg deleted the sarabee-vtadmin-fonts-n-colours branch November 1, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajm188 ajm188 ajm188 approved these changes

@deepthi deepthi Awaiting requested review from deepthi

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps

Assignees
No one assigned
Labels
Component: VTAdmin VTadmin interface
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@doeg @ajm188 @askdba @rohit-nayak-ps