[vtctld] vtctldclient command pkg #7321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're going to need this out of main in just a bit Signed-off-by: Andrew Mason <amason@slack-corp.com>
…unction Signed-off-by: Andrew Mason <amason@slack-corp.com>
- write docs - copy over Root and its related variables - copy over cell commands Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
doeg
approved these changes
Jan 19, 2021
| */ | ||
|
|
||
| /* | ||
| Package command contains the commands used by vtctldclient. It is intended only |
There was a problem hiding this comment.
Seriously, these docs are so so good.
ajm188
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Feb 11, 2021
…nd_pkg [vtctld] vtctldclient command pkg
setassociative
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Mar 11, 2021
…nd_pkg [vtctld] vtctldclient command pkg
ajm188
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Apr 6, 2021
…nd_pkg [vtctld] vtctldclient command pkg Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
added
Component: Cluster management
Type: Feature Request
and removed
Component: Build/CI
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves the command definitions and logic to a subpackage, to allow us to more easily break up commands into files logically, rather than shoving everything into a single "commands" file.
For testing, I validated I could still compile and run an rpc, which to me is enough confirmation this is a no-op.
Related Issue(s)
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: